Fix wrong use of ret code enumeration in logs #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 60.59% 60.43% -0.16%
==========================================
Files 65 65
Lines 1921 1921
Branches 543 543
==========================================
- Hits 1164 1161 -3
- Misses 437 440 +3
Partials 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ReturnCode::operator<<, a map indexed by ReturnCode was being used. However, in the initialisation of that map keys of type ReturnCode::ReturnCodeValue were being used. Thus, the constructor of ReturnCode was being implicitly called with a non-desired and implicit casting of the passed ReturnCodeValue to fastdds::dds::ReturnCode_t. This PR fix that behaviour.